Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of Life improvements #211

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Quality of Life improvements #211

merged 5 commits into from
Nov 14, 2024

Conversation

alilleybrinker
Copy link
Member

Assortment of quality of life improvements for the CLI codebase.

This is a general refactoring without logic changes; just restructures
command files into a module hierarchy to better accomodate addition of
future commands and more clearly distinguish common utilities from
commands. It also updates imports to be more consistent and compact.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
Add the ability to control logging verbosity in the CLI, and
simplify the format of log messages to be more compact.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
This replaces explicit panics with error logging.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
This fixes the snapshot tests to reflect the addition of verbosity
flags.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
This introduces a new `CommandOutput` trait, which ensures that any distinct
output message supports all formats.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker added type: feature New feature or request crate: omnibor-cli Relating to the omnibor-cli crate labels Nov 14, 2024
@alilleybrinker alilleybrinker self-assigned this Nov 14, 2024
@alilleybrinker alilleybrinker merged commit 772a9e6 into main Nov 14, 2024
10 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/qol branch November 14, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: omnibor-cli Relating to the omnibor-cli crate type: feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant