Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added snapshot tests for omnibor artifact id #213

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

alilleybrinker
Copy link
Member

This adds snapshot tests for all three formats of the omnibor artifact id subcommand, to catch formatting regressions in the future.

@alilleybrinker
Copy link
Member Author

Ooooh the hashes are different on Windows, presumably because of how Git automatically converts the line endings. This is... not ideal haha.

For now, since this intended to just be a UI test, I think the right answer would be a test filter to ignore GitOID contents.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/snapsnot_artifact_id branch from e8b9184 to cb6b54c Compare November 14, 2024 02:45
This adds snapshot tests for all three formats of the `omnibor artifact id`
subcommand, to catch formatting regressions in the future.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/snapsnot_artifact_id branch from cb6b54c to 6b38acc Compare November 14, 2024 17:35
@alilleybrinker alilleybrinker merged commit 0fc33c2 into main Nov 14, 2024
10 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/snapsnot_artifact_id branch November 14, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant