feat: Big refactor. #234
Merged
feat: Big refactor. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
type: feature
This refactor eliminates the `gitoid` crate, merging its key logic into the `omnibor` crate. It also substantially reorganizes the OmniBOR crate. There are too many changes to cover here, many of them minor. The most essential change is that cryptography providers and the hash algorithm type have been separated from each other. `Sha256` is now a marker type that can be produced by any compliant cryptography provider (RustCrypto, OpenSSL, and BoringSSL today), meaning that information about the identity of the cryptography provider doesn't leak into the identity of the resulting `ArtifactId` or `InputManifest`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/gitoid-crate-destroy
branch
from
067f439 to
063987b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor eliminates the
gitoidcrate, merging its key logic into theomniborcrate. It also substantially reorganizes the OmniBOR crate. There are too many changes to cover here, many of them minor.The most essential change is that cryptography providers and the hash algorithm type have been separated from each other.
Sha256is now a marker type that can be produced by any compliant cryptography provider (RustCrypto, OpenSSL, and BoringSSL today), meaning that information about the identity of the cryptography provider doesn't leak into the identity of the resultingArtifactIdorInputManifest.