Skip to content

Commit

Permalink
fix: fix linting issues in CI/CD
Browse files Browse the repository at this point in the history
  • Loading branch information
awpala committed Aug 6, 2023
1 parent b7b0d7e commit 72004eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions __tests__/utilities.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {

// types
type TInputPayload = {
// eslint-disable-next-line no-unused-vars
[T in TCourseId]: any;

Check warning

Code scanning / ESLint

disallow unused variables Warning test

'T' is defined but never used.
};

Expand Down
3 changes: 2 additions & 1 deletion firebase/__tests__/utilities.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
updateReviewsRecent,
ON_ADD_REVIEW,
ON_EDIT_REVIEW,
ON_DELETE_REVIEW,
} from '@backend/utilities';
import {
Review,
Expand All @@ -30,10 +29,12 @@ const _aggregateData = '_aggregateData';

// type definitions for mock responses data
type TMockReviewsRecentData = {
// eslint-disable-next-line no-unused-vars
[courseId in TCourseId | '_aggregateData']: Review[];

Check warning

Code scanning / ESLint

disallow unused variables Warning test

'courseId' is defined but never used.
};

type TMockReviewsData = {
// eslint-disable-next-line no-unused-vars
[courseId in TCourseId]: {

Check warning

Code scanning / ESLint

disallow unused variables Warning test

'courseId' is defined but never used.
[yearSemesterTerm: string]: TPayloadReviews;
};
Expand Down

0 comments on commit 72004eb

Please sign in to comment.