Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add update form #437

Merged
merged 47 commits into from
Aug 20, 2024
Merged

Feature: add update form #437

merged 47 commits into from
Aug 20, 2024

Conversation

tran-christian
Copy link
Contributor

@tran-christian tran-christian commented Aug 18, 2023

Added update for course reviews. Also updated the card to use toastui instead

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 0:18am

src/components/FormEditor.tsx Fixed Show fixed Hide fixed
src/components/FormEditor.tsx Fixed Show fixed Hide fixed
}
}}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [editorRef?.current?.getInstance().getMarkdown(), initialValue]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked.
awpala
awpala previously approved these changes Aug 19, 2024
);
setLoading(false);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selectedYear, selectedSemester]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'courseId', 'courseTimeline', and 'mutate'. Either include them or remove the dependency array.

type TSemesterMap = {
// eslint-disable-next-line no-unused-vars
[semesterId in TSemesterId]: Date;

Check warning

Code scanning / ESLint

disallow unused variables Warning

'semesterId' is defined but never used.
@omshub-admin omshub-admin merged commit 4cf9fb0 into main Aug 20, 2024
15 of 16 checks passed
@omshub-admin omshub-admin deleted the update-form branch August 20, 2024 00:49
@awpala awpala added this to the 1.0 - MVP milestone Aug 20, 2024
@awpala awpala linked an issue Aug 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add edit review functionality
3 participants