Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dark Mode #441

Merged
merged 19 commits into from
Aug 15, 2024
Merged

Feature: Dark Mode #441

merged 19 commits into from
Aug 15, 2024

Conversation

tran-christian
Copy link
Contributor

@tran-christian tran-christian commented Aug 23, 2023

  • Persistent state
  • Defaulted to system preferences
  • No screen flashing when first loading the page.

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 5:22am

pages/_app.tsx Fixed Show fixed Hide fixed
@awpala
Copy link
Contributor

awpala commented Aug 29, 2023

@ctran4347 FYI missing coloring for button in navbar, we should make this white as well:
image

@awpala
Copy link
Contributor

awpala commented Aug 29, 2023

@ctran4347 if this too scope-creeping, feel free to ignore for purposes of this particular PR, but the "standard blue" hyperlinks within the Reviews look kinda tacky, but especially in dark mode:
image

I think we should just switch these to one of the softer blue (or equivalent) colors from the palette; we can do the same changed link color for both light/dark mode (i.e., just hard-stylesheet it to the particular tag/attr), since it also looks tacky in light mode too (but it popped out even more when I noticed it in passing in dark mode, hence calling it out here for reference).

@awpala
Copy link
Contributor

awpala commented Sep 2, 2023

@ctran4347 another thing on this one...looks like the dark/light mode toggle isn't visible on mobile/responsive/scaled view, as verified on my end per preview on my mobile & tablet devices

Representative example here via mobile (similar for tablet):
image

@awpala awpala merged commit 28feb27 into main Aug 15, 2024
13 of 14 checks passed
@awpala awpala deleted the dark-mode branch August 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants