Remove deleted-by and deleted-at from the dataview serializer

onaio · Oct 19, 2024 · 7037691 · 7037691
1 parent 0cb0e29
commit 7037691
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/onadata/libs/serializers/dataview_serializer.py b/onadata/libs/serializers/dataview_serializer.py
@@ -124,6 +124,7 @@ class DataViewSerializer(serializers.HyperlinkedModelSerializer):
 
     class Meta:
         model = DataView
+        exclude = ["deleted_by", "deleted_at"]
         fields = (
             "dataviewid",
             "name",
@@ -138,8 +139,6 @@ class Meta:
             "has_hxl_support",
             "url",
             "date_created",
-            "deleted_at",
-            "deleted_by",
         )
         validators = [
             serializers.UniqueTogetherValidator(

diff --git a/onadata/libs/tests/serializers/test_dataview_serializer.py b/onadata/libs/tests/serializers/test_dataview_serializer.py
@@ -79,11 +79,8 @@ def test_no_error_thrown_for_a_dataview_with_deleted_by_set(self):
         serialized_dataview = DataViewSerializer(
             dataview, context={"request": request}
         ).data
-        self.assertEqual(
-            serialized_dataview["deleted_by"],
-            f"http://testserver/api/v1/users/{self.user.username}",
-        )
-        self.assertTrue("deleted_at" in serialized_dataview)
+        self.assertEqual(serialized_dataview["deleted_by"], None)
+        self.assertFalse("deleted_at" in serialized_dataview)
 
     def test_name_and_xform_are_unique(self):
         """