Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect client to download media directly from Amazon S3 / Azure Storage #2713

Merged
merged 21 commits into from
Oct 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove pdb break
kelvin-muchiri committed Oct 14, 2024
commit 9fadcf78d0ddc36cd038ef646793e6b592217ee9
2 changes: 1 addition & 1 deletion onadata/apps/api/tests/viewsets/test_export_viewset.py
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ def test_export_response(self):
request = self.factory.get("/export")
force_authenticate(request, user=self.user)
response = self.view(request, pk=export.pk)
self.assertIn(export.filename, response.get("Content-Disposition"))
self.assertIn(filename, response.get("Content-Disposition"))

def test_export_formats_present(self):
"""
4 changes: 0 additions & 4 deletions onadata/libs/utils/api_export_tools.py
Original file line number Diff line number Diff line change
@@ -714,8 +714,4 @@ def _new_export():
if Export.EXPORT_MIMES[ext] == "csv":
mimetype = "text/csv"

import ipdb

ipdb.set_trace()

return generate_media_download_url(export.filepath, mimetype, f"{filename}.{ext}")