CSV export optimisation #2755
Merged
CSV export optimisation #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
2695-csv-optimisation
branch
2 times, most recently
from
fefffc4 to
d993ac9
Compare
fix unnecessary-dict-index-lookup
suppress too-many-lines
kelvin-muchiri
force-pushed
the
2695-csv-optimisation
branch
from
a9994de to
17e4cbb
Compare
kelvin-muchiri
requested review from
FrankApiyo and
ukanga
and removed request for
FrankApiyo
FrankApiyo
reviewed
Jan 14, 2025
FrankApiyo
approved these changes
Jan 15, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Optimise CSV export process. Avoid traversing data to build CSV columns for repeat responses. Instead use a register that has a record of how many columns we should have for each repeat question.
If the register for a form is unavailable, fall back to building the columns from data and trigger an asynchronous task to create the register
Fixed flaky test
onadata.apps.api.tests.viewsets.test_organization_profile_viewset.TestOrganizationProfileViewSet.test_add_members_to_owner_roleSteps taken to verify this change does what is intended
Side effects of implementing this change
Faster CSV exports and loading of linked datasets
Before submitting this PR for review, please make sure you have:
Closes #2695