Clean up logic for validating recon form required fields

onaio · Nov 5, 2024 · 3f2a76c · 3f2a76c
1 parent 4ac9ca2
commit 3f2a76c
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/tally_ho/apps/tally/static/js/blank_field_check.js b/tally_ho/apps/tally/static/js/blank_field_check.js
@@ -1,20 +1,19 @@
 function validate_results(alertMessage) {
     const requiredElements = document.querySelectorAll('.required-input');
-    let allFilled = true;
-    console.log({ requiredElements })
+    let isFormValid = true;
     requiredElements.forEach(el => {
         const inputChild = el.querySelector('input');
         if (inputChild && inputChild.value.trim() === '') {
-            allFilled = false;
+            isFormValid = false;
             el.classList.add('has-error');
         } else if (inputChild) {
             el.classList.remove('has-error');
         }
     });
 
-    if (!allFilled) {
+    if (isFormValid === false) {
         alert(alertMessage);
-        return false;
+        return isFormValid;
     }
-    return true;
+    return isFormValid;
 }