[SYCLomatic] Fix incorrect filter for option "-optf" and duplicate compile commands in compilation database due to working directory ignoring for intercept-build tool #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomflinda
commented
Sep 20, 2023
tomflinda
commented
- Fix incorrect process for option "-optf" short for “--options-file”
- Fix incorrect working directory for compile command like “cd inner_dir && nvcc -o foo foo.cu”
…pt-build toola 1. Fix incorrect process for option -optf short for “--options-file” 2. Fix incorrect working directory for compile command like “cd inner_dir && nvcc -o foo foo.cu” Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
tomflinda
changed the title
Signed-off-by: chenwei.sun <[email protected]>
|
behavior test for this PR has been submitted to SYCLomatic-test repo: oneapi-src/SYCLomatic-test#474 |
tomflinda
changed the title
zhiweij1
approved these changes
Sep 21, 2023
tomflinda
changed the title
tomflinda
changed the title
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…on database generation when source file builds with "-optf" of intercept-build tool (oneapi-src#474) Signed-off-by: chenwei.sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.