Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Emit warning for shared local memory if the data type defined by using or typedef #1822

Merged
merged 16 commits into from
Apr 15, 2024

Conversation

zhiweij1
Copy link
Contributor

Signed-off-by: Jiang, Zhiwei [email protected]

…fined by using or typedef

Signed-off-by: Jiang, Zhiwei <[email protected]>
@zhiweij1 zhiweij1 requested a review from a team as a code owner March 25, 2024 09:04
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
void run_foo8() {
// CHECK: int i;
// CHECK-NEXT: /*
// CHECK-NEXT: DPCT1124:{{[0-9]+}}: The type "Tk" defined in function "foo_device7" is used as the parameter type in all functions in the call path from the corresponding sycl::handler::parallel_for() to the current function. You may need to adjust the type definition location.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// CHECK-NEXT: DPCT1124:{{[0-9]+}}: The type "Tk" defined in function "foo_device7" is used as the parameter type in all functions in the call path from the corresponding sycl::handler::parallel_for() to the current function. You may need to adjust the type definition location.
// CHECK-NEXT: DPCT1124:{{[0-9]+}}: The type "Tk" defined in function "foo_device7" is used as the parameter type in all functions in the call path from the sycl::handler::parallel_for() to the "foo_device7" function. You may need to adjust the type definition location.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit 5026e1b into oneapi-src:SYCLomatic Apr 15, 2024
20 checks passed
@zhiweij1 zhiweij1 deleted the warning branch April 16, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants