Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Refine the migration of some cublas API which has cublasComputeType_t argument #1826

Merged
merged 27 commits into from
Apr 23, 2024

Conversation

zhiweij1
Copy link
Contributor

@zhiweij1 zhiweij1 commented Mar 26, 2024

Signed-off-by: Jiang, Zhiwei [email protected]

Signed-off-by: Jiang, Zhiwei <[email protected]>
@zhiweij1 zhiweij1 marked this pull request as ready for review March 27, 2024 03:39
@zhiweij1 zhiweij1 requested a review from a team as a code owner March 27, 2024 03:39
@zhiweij1 zhiweij1 requested review from tangjj11 and wenhuiNi March 27, 2024 03:39
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
Signed-off-by: Jiang, Zhiwei <[email protected]>
@zhiweij1 zhiweij1 marked this pull request as draft March 28, 2024 05:07
@zhiweij1 zhiweij1 marked this pull request as ready for review April 10, 2024 09:24
@zhiweij1 zhiweij1 changed the title compute mode refine [SYCLomatic] Refine the migration of some cublas API which has cublasComputeType_t argument Apr 15, 2024
Signed-off-by: Jiang, Zhiwei <[email protected]>
@zhiweij1
Copy link
Contributor Author

zhiweij1 commented Apr 16, 2024

The failed cases are expected. They will be updated in oneapi-src/SYCLomatic-test#682.

Copy link
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit c30a9b5 into oneapi-src:SYCLomatic Apr 23, 2024
22 checks passed
@zhiweij1 zhiweij1 deleted the compute_mode branch April 23, 2024 00:33
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
…ts/query-api-mapping temporarily (oneapi-src#686)

Signed-off-by: Jiang, Zhiwei <[email protected]>
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants