-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic][CMake] Emit warning msg when CUDA-specific command is not supported during CMake script migration #1845
Merged
zhimingwang36
merged 9 commits into
oneapi-src:SYCLomatic
from
tomflinda:add_warning_msg_not_supported_cmake_syntax
Apr 12, 2024
Merged
[SYCLomatic][CMake] Emit warning msg when CUDA-specific command is not supported during CMake script migration #1845
zhimingwang36
merged 9 commits into
oneapi-src:SYCLomatic
from
tomflinda:add_warning_msg_not_supported_cmake_syntax
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflinda
changed the title
[SYCLomatic][CMake] Emit warning msg when CUDA specific command is not supported during CMake script migration
[SYCLomatic][CMake] Emit warning msg when CUDA specific command is not supported during CMake script migration and refine the processing msg
Apr 1, 2024
tomflinda
force-pushed
the
add_warning_msg_not_supported_cmake_syntax
branch
from
April 1, 2024 01:38
436c21f
to
0f4d09c
Compare
tomflinda
changed the title
[SYCLomatic][CMake] Emit warning msg when CUDA specific command is not supported during CMake script migration and refine the processing msg
[SYCLomatic][CMake] Emit warning msg when CUDA specific command is not supported during CMake script migration
Apr 1, 2024
zhiweij1
reviewed
Apr 1, 2024
tomflinda
force-pushed
the
add_warning_msg_not_supported_cmake_syntax
branch
2 times, most recently
from
April 1, 2024 09:57
9c43b77
to
5f510e9
Compare
zhiweij1
reviewed
Apr 2, 2024
tomflinda
force-pushed
the
add_warning_msg_not_supported_cmake_syntax
branch
from
April 2, 2024 01:10
fd69398
to
b8f4073
Compare
zhiweij1
approved these changes
Apr 2, 2024
tomflinda
changed the title
[SYCLomatic][CMake] Emit warning msg when CUDA specific command is not supported during CMake script migration
[SYCLomatic][CMake] Emit warning msg when CUDA-specific command is not supported during CMake script migration
Apr 3, 2024
tomflinda
force-pushed
the
add_warning_msg_not_supported_cmake_syntax
branch
2 times, most recently
from
April 7, 2024 02:42
b3268d4
to
47e6486
Compare
tomflinda
force-pushed
the
add_warning_msg_not_supported_cmake_syntax
branch
3 times, most recently
from
April 9, 2024 03:22
e8f7133
to
0a886ec
Compare
…t supported during CMake script migration Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
Signed-off-by: chenwei.sun <[email protected]>
ShengchenJ
approved these changes
Apr 11, 2024
zhimingwang36
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenwei.sun [email protected]