[SYCLomatic] return device_pointer from data() #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmiesmith
requested changes
Apr 3, 2024
danhoeflinger
force-pushed
the
dev/dhoeflin/data_return_device_ptr
branch
from
8c8042d to
20a27a6
Compare
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
force-pushed
the
dev/dhoeflin/data_return_device_ptr
branch
from
20a27a6 to
b58429b
Compare
ziranzha
reviewed
Apr 18, 2024
| using pointer = T *; | ||
| using const_pointer = const T *; | ||
| using pointer = device_pointer<T>; | ||
| using const_pointer = const device_pointer<T>; |
There was a problem hiding this comment.
Should const_pointer be defined as device_pointer<const T>?
There was a problem hiding this comment.
Good catch. Fixed, thanks!
Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for data() function return and
pointertypedef fordevice_vectorto usedevice_pointerI don't know the motivation for originally using
T*rather thandevice_pointer<T>. This passes the tests for vector. It seems that this should be a reasonable change.