Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][SYCLomatic][DOC] Update API migration status April 2024 #1875

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

yihanwg
Copy link
Contributor

@yihanwg yihanwg commented Apr 12, 2024

No description provided.

@yihanwg yihanwg marked this pull request as ready for review April 12, 2024 06:07
Copy link
Contributor

@tangjj11 tangjj11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cudaBindTextureToMipmappedArray and 4 math APIs LGTM.

@oscarbg
Copy link

oscarbg commented Apr 14, 2024

Hi,
sorry for asking here, it's nice to see monthly progress of this migration tool, but can I ask how this progress is correlated to Intel Oneapi releases? i.e. using current/latest Intel OneAPI 2024.1, and once this PR is merged and using a release with a daily build will be able to migrate and run projects using cudaBindTextureToMipmappedArray for ex.?
thanks..

@zhiweij1
Copy link
Contributor

zhiweij1 commented Apr 15, 2024

Hi, sorry for asking here, it's nice to see monthly progress of this migration tool, but can I ask how this progress is correlated to Intel Oneapi releases? i.e. using current/latest Intel OneAPI 2024.1, and once this PR is merged and using a release with a daily build will be able to migrate and run projects using cudaBindTextureToMipmappedArray for ex.? thanks..

Hi @oscarbg , the migration of cudaBindTextureToMipmappedArray is already supported. The most accurate method to
check if an API is supported to be migrated is searching its name in APINames*.inc files (E.g., https://github.com/oneapi-src/SYCLomatic/blob/SYCLomatic/clang/lib/DPCT/APINames.inc#L354). Because the changes in APINames*.inc files are almost always contained in the migration implementation PR. So using any daily build after that time can migrate the API.

And checking the files updated in this PR can also get the same information. But there will be some lag since they are updated monthly.

For the oneAPI release, I think 2024.2 will contain these supports.

Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscarbg
Copy link

oscarbg commented Apr 15, 2024

Hi, sorry for asking here, it's nice to see monthly progress of this migration tool, but can I ask how this progress is correlated to Intel Oneapi releases? i.e. using current/latest Intel OneAPI 2024.1, and once this PR is merged and using a release with a daily build will be able to migrate and run projects using cudaBindTextureToMipmappedArray for ex.? thanks..

Hi @oscarbg , the migration of cudaBindTextureToMipmappedArray is already supported. The most accurate method to check if an API is supported to be migrated is searching its name in APINames*.inc files (E.g., https://github.com/oneapi-src/SYCLomatic/blob/SYCLomatic/clang/lib/DPCT/APINames.inc#L354). Because the changes in APINames*.inc files are almost always contained in the migration implementation PR. So using any daily build after that time can migrate the API.

And checking the files updated in this PR can also get the same information. But there will be some lag since they are updated monthly.

For the oneAPI release, I think 2024.2 will contain these supports.

thanks for answering! very informative..

@ziranzha ziranzha merged commit 7aad00f into oneapi-src:SYCLomatic Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants