[SYCLomatic] Add support for two-way type-cast from dpct::kernel_library and dpct::kernel_function to uint64_t conversion
#2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Jan 8, 2025
zhiweij1
approved these changes
Jan 8, 2025
the-slow-one
commented
Jan 8, 2025
zhiweij1
approved these changes
Jan 8, 2025
ShengchenJ
approved these changes
Jan 8, 2025
keryell
reviewed
Jan 8, 2025
the-slow-one
changed the title
dpct::kernel_libaray to u64 conversiondpct::kernel_library to u64 conversion
the-slow-one
commented
Jan 8, 2025
the-slow-one
changed the title
dpct::kernel_library to u64 conversiondpct::kernel_library and dpct::kernel_function to u64 conversion
the-slow-one
changed the title
dpct::kernel_library and dpct::kernel_function to u64 conversiondpct::kernel_library and dpct::kernel_function to uint64_t conversion
zhiweij1
approved these changes
Jan 8, 2025
ShengchenJ
approved these changes
Jan 9, 2025
zhimingwang36
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CUmoduleis a pointer to a structure which results in a valid conversion fromuint64_ttoCUmoduleinstance. Also, the same can be said about theCUfunction.This PR allows the "bi-directional" type-cast for
dpct::kernel_libraryanddpct::kernel_function.Signed-off-by: Deepak Raj H R