[SYCLomatic] null_type #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Hoeflinger <[email protected]>
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| namespace dpct { | |||
|
|
|||
| struct null_type {}; | |||
There was a problem hiding this comment.
this PR doesn't show the use of null_type{}. So not sure how it is used and why it is necessary to add null_type.
There was a problem hiding this comment.
I've just added a new PR into SYCLomatic-test which shows the intended usage of dpct::null_type.
oneapi-src/SYCLomatic-test#219
It will also likely be used in future dpct helper header APIs to a similar effect.
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…i-src#528) Signed-off-by: Tang, Jiajun [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for dpct::null_type for to indicate the lack of argument.