Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Power CTS to remove Card Power Domain specific tests #140

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update Power CTS to remove Card Power Domain specific tests #140

merged 1 commit into from
Jan 28, 2025

Conversation

anvesh-intel
Copy link
Contributor

Related-To: NEO-13701

Signed-off-by: Anvesh Bakwad [email protected]

@anvesh-intel
Update Power CTS to remove Card Power Domain specific tests
dcfe58b 
Related-To: NEO-13701

Signed-off-by: Anvesh Bakwad <[email protected]>
shubskmr
shubskmr reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@shubskmr shubskmr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All power tests are passing now I assume on BMG windows? Could you add the logs for BMG (has card domain support) and DG2 (doesn't have card domain support) as well similar to how you have added linux results in the NEO?

@anvesh-intel
Copy link
Contributor Author

anvesh-intel commented Jan 27, 2025 •
edited
Loading

All power tests are passing now I assume on BMG windows? Could you add the logs for BMG (has card domain support) and DG2 (doesn't have card domain support) as well similar to how you have added linux results in the NEO?

I've attached DG2 and BMG windows results in the JIRA.
DG2 : Results are same with and without this PR.
BMG: Previous to this PR, not all tests were passing. With this PR all the existing failing tests are still failing, along with GivenValidPowerHandlesAfterGettingMaxPowerLimitWhenSettingValuesForPeakPowerThenExpectzesPowerGetLimitsExtToReturnPowerLimitsLessThanMaxPowerLimits for CARD Domain power handle.
I've mentioned all the tests failure causes in the JIRA.

shubskmr
shubskmr approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@shubskmr shubskmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshwinKumarKulkarni AshwinKumarKulkarni merged commit 4b6aca7 into oneapi-src:master Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikbariintel pratikbariintel pratikbariintel approved these changes

@AshwinKumarKulkarni AshwinKumarKulkarni AshwinKumarKulkarni approved these changes

@shubskmr shubskmr shubskmr approved these changes

@vishnu-khanth vishnu-khanth Awaiting requested review from vishnu-khanth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anvesh-intel @shubskmr @AshwinKumarKulkarni @pratikbariintel