fix: do not access UMD-managed SVM-allocation while in-use #141
+0
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is illegal with UMD-managed migrations to access a SVM-allocation
from CPU side while it is still in-use on GPU side. In such scenario
a CPU-side access triggers data fetch from GPU-side and then any
subsequent GPU-side modification will not be observable on the CPU-side.
With UMD-managed migrations there is no way to tell the GPU that it
should fetch the allocation again from CPU-side before modifying it.
The removed
EXPECT_NE
statements are not mandatory for the goals ofthe tests while their side-effects make things worse.
Signed-off-by: Maciej Bielski [email protected]