Fix build when using clang-cl on Windows #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Clang front-end provided with Visual Studio, `clang-cl.exe`, does not support the `/Qspectre` or `/MP` compiler flags. This patch adds logic to check that the `CMAKE_C_COMPILER_ID`/`CMAKE_CXX_COMPILER_ID` variables are not `Clang` before appending the unsupported flags to `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS`. Signed-off-by: Kenneth Benzie (Benie) <[email protected]>
nrspruit
approved these changes
Nov 30, 2023
lisanna-dettwyler
pushed a commit
to lisanna-dettwyler/level-zero
that referenced
this pull request
Jan 23, 2024
The Clang front-end provided with Visual Studio, `clang-cl.exe`, does not support the `/Qspectre` or `/MP` compiler flags. This patch adds logic to check that the `CMAKE_C_COMPILER_ID`/`CMAKE_CXX_COMPILER_ID` variables are not `Clang` before appending the unsupported flags to `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS`. Signed-off-by: Kenneth Benzie (Benie) <[email protected]>
Jemale
pushed a commit
to Jemale/level-zero
that referenced
this pull request
Jun 17, 2024
The Clang front-end provided with Visual Studio, `clang-cl.exe`, does not support the `/Qspectre` or `/MP` compiler flags. This patch adds logic to check that the `CMAKE_C_COMPILER_ID`/`CMAKE_CXX_COMPILER_ID` variables are not `Clang` before appending the unsupported flags to `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS`. Signed-off-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clang front-end provided with Visual Studio,
clang-cl.exe, does not support the/Qspectreor/MPcompiler flags. This patch adds logic to check that theCMAKE_C_COMPILER_ID/CMAKE_CXX_COMPILER_IDvariables are notClangbefore appending the unsupported flags toCMAKE_C_FLAGS/CMAKE_CXX_FLAGS.