Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to ABI check with last released tag #220

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Oct 15, 2024

Expanded ABI checker workflow to verify both the previous commit and the previous release tag.

@nrspruit nrspruit changed the title Abi check release Update workflows to ABI check with last released tag Oct 15, 2024
@nrspruit nrspruit marked this pull request as ready for review October 15, 2024 17:50
@nrspruit
Copy link
Contributor Author

@lisanna-dettwyler / @Jemale / @rwmcguir please let me know if we can add this to the CI, this will catch more ABI issues related to breaking backwards compatibility with previous releases.

Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to condense this into being a matrix job, but that refactor can happen later

@lisanna-dettwyler lisanna-dettwyler merged commit b81b24e into oneapi-src:master Oct 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants