Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal required CMake version #221

Merged

Conversation

lukaszstolarczuk
Copy link
Contributor

Currently, it doesn't configure properly on cmake-3.5.0 with 2 errors:

-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.43.0")
CMake Error at CMakeLists.txt:51 (include):
  include could not find load file:

    FetchContent

-- Performing Test COMPILER_SUPPORTS_CXX14
-- Performing Test COMPILER_SUPPORTS_CXX14 - Success
CMake Error at source/layers/validation/CMakeLists.txt:39 (install):
  install TARGETS given unknown argument "NAMELINK_COMPONENT".

CMake Error at source/layers/tracing/CMakeLists.txt:51 (install):
  install TARGETS given unknown argument "NAMELINK_COMPONENT".

-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
CMake Error at source/CMakeLists.txt:51 (install):
  install TARGETS given unknown argument "NAMELINK_COMPONENT".

-- Configuring incomplete, errors occurred!

The minimal version required for failing features are:


I also double-checked this with a tool: https://github.com/nlohmann/cmake_min_version :

@luke   venv  ~/repos/cmake_min_version: python cmake_min_version.py ~/repos/luke/level-zero/
Found 9 CMake binaries from directory tools in 0.27 seconds

[  0%] CMake 3.9.0  ✘ error
       CMakeLists.txt:51 (include)
[ 25%] CMake 3.11.0 ✘ error
       source/layers/validation/CMakeLists.txt:39 (install)
[ 50%] CMake 3.12.0 ✔ works
[100%] Minimal working version: CMake 3.12.0

cmake_minimum_required(VERSION 3.12.0)

Currently, it doesn't configure properly on cmake-3.5.0 with 2 errors:
- CMake Error at CMakeLists.txt:51 (include)
  include could not find load file: FetchContent
- CMake Error at source/layers/validation/CMakeLists.txt:39 (install):
  install TARGETS given unknown argument "NAMELINK_COMPONENT".

Signed-off-by: Łukasz Stolarczuk <[email protected]>
@lisanna-dettwyler lisanna-dettwyler merged commit 331ba03 into oneapi-src:master Oct 31, 2024
25 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the bump-cmake-version branch November 4, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants