-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO_NOT_MERGE] Static L0 Loader Support #224
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
example output: [----------] Global test environment tear-down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments from looking at it briefly
"" | ||
${CMAKE_CURRENT_BINARY_DIR}/ZeLoaderVersion.rc | ||
) | ||
if (DYNAMIC_LOAD_LOADER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend the top level cmake option be named after the result rather than the behavior, like BUILD_STATIC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, that would differentiate.
auto loaderTracingLayerInit = reinterpret_cast<zelLoaderTracingLayerInit_t>( | ||
GET_FUNCTION_PTR(loader, "zelLoaderTracingLayerInit") ); | ||
if (loaderTracingLayerInit == nullptr) { | ||
printf("missing loaderTracingLayerInit\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be going to stderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, I was going to convert the printfs to debug trace logs for the ones we determine useful.
Very early draft of the static Loader.
This works with the current version of the loader, but there is some versioning checks we will want to do.
Posting this to start the development process and start feedback.