Fix/Regenerate the Loader files incorrectly reordered by the scripts. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
requested review from
Jemale,
rwmcguir,
aravindksg,
bmyates and
lisanna-dettwyler
nrspruit
force-pushed
the
fix_loader_gen_script_reorder
branch
from
d46f88d
to
bf20966
Compare
rwmcguir
previously approved these changes
Oct 31, 2024
- Removed input.json file that is generated by the spec scripts. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_loader_gen_script_reorder
branch
from
bf20966
to
a8cec22
Compare
lisanna-dettwyler
approved these changes
Oct 31, 2024
rwmcguir
approved these changes
Oct 31, 2024
aravindksg
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous script gen accidently reordered the layers/loader files incorrectly and did not put them back.
This fix correctly addresses the invalid reorder to match the updated script generation.