Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: graph: document for complex fusions #2278

Merged
merged 9 commits into from
Dec 20, 2024
Merged

doc: graph: document for complex fusions #2278

merged 9 commits into from
Dec 20, 2024

Conversation

TaoLv
Copy link
Contributor

@TaoLv TaoLv commented Dec 17, 2024

  1. Created a dedicate document folder for fusion patterns.
  2. Add documents for GQA and gated MLP.
  3. Improve the existing SDPA document: mention the MQA example, explain the memory consumption for reference implementation, fix wording, etc.
  4. Remove legacy graph compiler patterns.

@TaoLv TaoLv requested review from a team as code owners December 17, 2024 05:15
@github-actions github-actions bot added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Dec 17, 2024
@TaoLv TaoLv force-pushed the lvtao/main/doc-complex-fusion branch from 5d4a93e to 24a955f Compare December 17, 2024 14:39
@vpirogov
Copy link
Member

Looks nice, @TaoLv.

ranukund
ranukund approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ranukund ranukund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the fusion_patterns.md file. The fusion_patterns.md is an exisiting file which was not reviewed earlier. Please incorporate as you see fit, thanks Tao

doc/graph/fusion_patterns/fusion_patterns.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/fusion_patterns.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/fusion_patterns.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/fusion_patterns.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/fusion_patterns.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/gqa.md Outdated Show resolved Hide resolved
doc/graph/fusion_patterns/gqa.md Outdated Show resolved Hide resolved
@TaoLv TaoLv force-pushed the lvtao/main/doc-complex-fusion branch 2 times, most recently from 95c6ea4 to 6e1f3fd Compare December 18, 2024 14:43
@TaoLv
Copy link
Contributor Author

TaoLv commented Dec 18, 2024

Minor comments on the fusion_patterns.md file. The fusion_patterns.md is an exisiting file which was not reviewed earlier. Please incorporate as you see fit, thanks Tao

Thank you @ranukund . The suggestions are incorporated now.

@TaoLv TaoLv force-pushed the lvtao/main/doc-complex-fusion branch from 6e1f3fd to 7de77da Compare December 18, 2024 14:45
@TaoLv
Copy link
Contributor Author

TaoLv commented Dec 19, 2024

make test
disable device_cpu
disable device_gpu
enable build_docs

@TaoLv TaoLv merged commit 715b4e9 into main Dec 20, 2024
18 of 24 checks passed
@TaoLv TaoLv deleted the lvtao/main/doc-complex-fusion branch December 20, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElaineBao ElaineBao ElaineBao approved these changes

@vpirogov vpirogov vpirogov approved these changes

@ranukund ranukund ranukund approved these changes

Assignees
No one assigned
Labels
documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TaoLv @vpirogov @ElaineBao @ranukund