xe: enable source code information for OpenCL kernels #2339
+141
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:gpu-intel
rjoursler
force-pushed
the
rjoursle/debug_ocl
branch
2 times, most recently
from
2f603aa to
d91f4d4
Compare
|
make test |
petercad
approved these changes
Jan 6, 2025
mgouicem
reviewed
Jan 9, 2025
rjoursler
force-pushed
the
rjoursle/debug_ocl
branch
4 times, most recently
from
da403a2 to
983b765
Compare
rjoursler
force-pushed
the
rjoursle/debug_ocl
branch
from
983b765 to
7731a93
Compare
avmanerikar
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the difficult case for handling nGEN was already handled in #2297, it seems only fitting to enable debug information in the simpler case where we use OpenCL C kernels. This PR limits the scope of support for this to Linux due to the nuances required for handling temporary files. It should be fairly easy to extend with Windows support when it becomes useful.