-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xe: conv_v2: enable Stream-K kernels #2345
Open
echeresh
wants to merge
14
commits into
main
Choose a base branch
from
echeresh/echeresh/streamk-enable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e562a4d
xe: conv_v2: update README
echeresh 5004397
xe: jit: utils: extend hex (de)serialize functions
echeresh 36cd02e
xe: jit: utils: introduce parse result
echeresh eb336ee
xpu: ocl, sycl: profiler: add per-kernel time query
echeresh 3dcb49c
xe: conv_v2: remove unused code
echeresh eba3852
xe: conv_v2: fix BWD_D data type check
echeresh ef22d54
xe: conv_v2: introduce bench_time_t
echeresh 3d612f6
xe: conv_v2: handle descriptor defaults in one place
echeresh 7fbf427
xe: conv_v2: update planner logic
echeresh 1aeb360
xe: conv_v2: generalize performance modeling
echeresh 5492d31
x64: fix copyrights
echeresh f4dd9a2
xe: jit: add atomic_add for int data type
echeresh dbc96ca
xe: conv_v2: enable Stream-K kernels
echeresh f766ccd
xe: conv_v2: remove hw from kernel descriptor
echeresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,5 @@ | ||||||
/******************************************************************************* | ||||||
* Copyright 2023-2024 Intel Corporation | ||||||
* Copyright 2023-2025 Intel Corporation | ||||||
* | ||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
* you may not use this file except in compliance with the License. | ||||||
|
@@ -239,6 +239,8 @@ struct deserializer_t { | |||||
} | ||||||
} | ||||||
|
||||||
bool empty() const { return idx >= s.get_data().size(); } | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
size_t idx; | ||||||
const serialized_data_t &s; | ||||||
}; | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
into<int>(v)
This conversion is perfectly safe, the suggestion is largely to prevent additional noise when searching for conversion issues. On the other hand, all unsafe conversion should go through
into<T>
to enable runtime validation in debug builds.