Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xe: fix various GEMM issues on XeLP #2373

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

xe: fix various GEMM issues on XeLP #2373

wants to merge 4 commits into from
+71 −29

Conversation

rjoursler
Copy link
Contributor

@rjoursler rjoursler commented Jan 10, 2025 •
edited
Loading

Fixes an emulate gap uncovered by #2276 , a support gap uncovered by #2289, and fixes a type conversion issue uncovered by #2289.

@rjoursler rjoursler requested a review from a team as a code owner January 10, 2025 22:42
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Jan 10, 2025
@rjoursler
xe: jit: use switch for qword mov emulation
62686ed 
Simplifies logic for which cases are supported. Additionally enables a few more
simple conversions.
@rjoursler
xe: ocl: support int->int load and write
765eced 
This is necessary for reading and writing accumulators with type s32.
@rjoursler
Copy link
Contributor Author

make test
disable device_cpu
enable device_gpu
enable arch_xe-lp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atkassen atkassen atkassen approved these changes

@petercad petercad petercad approved these changes

Assignees
No one assigned
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjoursler @petercad @atkassen