Fix build with hwloc support disabled #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`umfMemspaceCreateFromNumaArray` is defined in `memspaces/memspace_numa.c` which is only added to the build if hwloc is enabled. When hwloc is enabled this is added as an optional symbol to the linker script through `UMF_OPTIONAL_SYMBOLS_LINUX`. When hwloc is disabled this symbol isn't available so this linker script would fail, I believe the correct fix is just to remove the symbol from the linker script.
bratpiorka
approved these changes
Oct 7, 2024
|
@npmiller could you provide the cmake flags? I would like to have this scenario added to the CI |
|
The variable is If |
PatKamin
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
umfMemspaceCreateFromNumaArrayis defined inmemspaces/memspace_numa.cwhich is only added to the build if hwloc is enabled.When hwloc is enabled this is added as an optional symbol to the linker script through
UMF_OPTIONAL_SYMBOLS_LINUX.When hwloc is disabled this symbol isn't available so this linker script would fail, I believe the correct fix is just to remove the symbol from the linker script.
I ran into this issue while building DPC++ with hwloc disabled.
Checklist