Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock_adapter tests fail with an odd message #2212

Open
lukaszstolarczuk opened this issue Oct 16, 2024 · 4 comments
Open

mock_adapter tests fail with an odd message #2212

lukaszstolarczuk opened this issue Oct 16, 2024 · 4 comments
Assignees

Comments

@lukaszstolarczuk
Copy link
Contributor

mock_adapter tests fail with an odd message:

--backend not valid; expected one of [LEVEL_ZERO, L0, OPENCL, CUDA, HIP, NATIVE_CPU, UNKNOWN, MOCK], but got `MOCK`

On the side note, I'm not sure if adapter_mock tests are run anywhere in the CI, so this should be fixed by the way, I guess.

Reproduction steps:

cmake ..
make
ctest --output-on-failure -R  event-adapter_mock-loader  # or selected other adapter_mock tests

Found on main (568a96a). Most likely related to: #2168

@RossBrunton
Copy link
Contributor

Looks like the logic was kind of broken when selecting mock devices (which don't really have a backend), sorry about that.

Can you check #2213 (or just removing --backend=${backend} from test/conformance/CMakeLists.txt) and seeing if that works?

@lukaszstolarczuk
Copy link
Contributor Author

Ok, I checked your PR and the odd message is gone. On the other hand I got this:

ctest --output-on-failure -R  event-adapter_mock-loader
Test project /home/luke/repos/luke/ur/build
    Start 14: event-adapter_mock-loader
1/1 Test #14: event-adapter_mock-loader ........***Failed    0.00 sec
/home/luke/repos/luke/ur/test/conformance/source/environment.cpp:213: Failure
Failed
No platforms were found with the following filters: (none)
Available platforms:

[==========] Running 13 tests from 1 test suite.
[----------] Global test environment set-up.
/home/luke/repos/luke/ur/test/conformance/source/environment.cpp:238: Failure
Failed
urDevicesGet() failed to get number of devices.
/home/luke/repos/luke/ur/test/conformance/source/environment.cpp:425: Failure
Failed
urDevicesGet() failed to get number of devices.
[----------] 13 tests from GoogleTestVerification
[ RUN      ] GoogleTestVerification.UninstantiatedParameterizedTestSuite<urEventGetInfoTest>
/home/luke/repos/luke/ur/test/conformance/event/urEventGetInfo.cpp:10: Skipped

[  SKIPPED ] GoogleTestVerification.UninstantiatedParameterizedTestSuite<urEventGetInfoTest> (0 ms)

Not sure though if my dev PC is suitable for this test or perhaps something still requires fixing...

Anyway, still wondering - should we run adapter_mock tests somewhere in the CI?

@RossBrunton
Copy link
Contributor

Darn. I'm getting the same thing, however I was also getting it on a commit before #2168 , so I just assumed it was my system being wonky. I'll look into it a bit more then, thanks for testing.

Anyway, still wondering - should we run adapter_mock tests somewhere in the CI?

Created a separate issue to track this: #2215

@lukaszstolarczuk
Copy link
Contributor Author

Great, make sense. So, once #2213 is merged we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants