Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI testing for "mock" adapter #2215

Closed
RossBrunton opened this issue Oct 17, 2024 · 0 comments · Fixed by #2218
Closed

Improve CI testing for "mock" adapter #2215

RossBrunton opened this issue Oct 17, 2024 · 0 comments · Fixed by #2218

Comments

@RossBrunton
Copy link
Contributor

As seen in #2212 , a bug arose when trying to run the mock adapter. However, CI reports all green, especially with a commit that broke the mock adapter.

We should implement proper CI testing for the mock adapter.
@RossBrunton RossBrunton mentioned this issue Oct 17, 2024
Open
RossBrunton added a commit to RossBrunton/unified-runtime that referenced this issue Oct 17, 2024
@RossBrunton
[NFC] Don't run conformance tests on mock adapter
d2e5bcd 
Closes: oneapi-src#2215
@RossBrunton RossBrunton mentioned this issue Oct 17, 2024
Merged
RossBrunton added a commit to RossBrunton/unified-runtime that referenced this issue Oct 17, 2024
@RossBrunton
[NFC] Don't run conformance/asan tests on mock adapter
3568dbc 
Closes: oneapi-src#2215
RossBrunton added a commit to RossBrunton/unified-runtime that referenced this issue Oct 17, 2024
@RossBrunton
[NFC] Don't run conformance/asan tests on mock adapter
ed0721a 
Closes: oneapi-src#2215
RossBrunton added a commit to RossBrunton/unified-runtime that referenced this issue Oct 17, 2024
@RossBrunton
[NFC] Don't run conformance tests on mock adapter
40be6c0 
Closes: oneapi-src#2215
igchor pushed a commit to igchor/unified-runtime that referenced this issue Oct 18, 2024
@RossBrunton @igchor
[NFC] Don't run conformance tests on mock adapter
2ea5b7e 
Closes: oneapi-src#2215
aarongreig pushed a commit to aarongreig/unified-runtime that referenced this issue Oct 22, 2024
@RossBrunton @aarongreig
[NFC] Don't run conformance tests on mock adapter
a11443b 
Closes: oneapi-src#2215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NFC] Don't run conformance tests on mock adapter RossBrunton/unified-runtime
1 participant
@RossBrunton