Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXP][OpenCL] Update kernel commands in a command-buffer #1358

Merged
merged 2 commits into from
Apr 23, 2024

Commits on Apr 22, 2024

  1. [EXP][Command-buffer] OpenCL kernel command update

    Implement the API for updating the kernel commands in a command-buffer
    defined by oneapi-src#1089 for
    the OpenCL adapter.
    
    However, the following changes to the UR kernel update API have been
    made based on implementation experience:
    
    1. Forbid updating the work-dim of the kernel, see KhronosGroup/OpenCL-Docs#1057
    2. Remove struct fields to update exec info, after [DPC++ implementation
       prototype](intel/llvm#12840) shows this isn't
       needed.
    3. Forbid changing the local work size from user to impl defined and
       vice-versa. See discussion in [L0 implementation
    PR](oneapi-src#1353 (comment)).
    
    This adapter implementation depends on support for the
    [cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch)
    extension.
    
    Tested on Intel GPU/CPUs OpenCL implementations with the
    [command-buffer emulation
    layer](https://github.com/bashbaug/SimpleOpenCLSamples/tree/main/layers/10_cmdbufemu).
    
    ```bash
    $ OPENCL_LAYERS=<path/to/SimpleOpenCLSamples/build/layers/10_cmdbufemu/libCmdBufEmu.so> ./bin/test-exp_command_buffer --platform="Intel(R) OpenCL Graphics"
    ```
    
    DPC++ PR intel/llvm#12724
    EwanC committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1397916 View commit details
    Browse the repository at this point in the history
  2. Update CTS match files

    EwanC committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c3c5406 View commit details
    Browse the repository at this point in the history