[L0] fix a deadlock on a recursive event rwlock #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.40%
==========================================
Files 250 241 -9
Lines 36220 36242 +22
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31732 +932
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
nrspruit
approved these changes
Mar 22, 2024
L0, when creating a list of events to wait on, in some cases was first grabbing a lock on a potentially completed event, and then tried to get a command list, which sometimes needs to cleanup all completed events. This caused a deadlock. This patch moves getting a command list to before the event lock. But because the lock is required to decide whether this command list actually needed, we might be wasting time here.
pbalcer
force-pushed
the
l0-recursive-event-deadlock
branch
from
3a64d79
to
39c0023
Compare
nrspruit
approved these changes
Mar 22, 2024
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Apr 8, 2024
…adlock [L0] fix a deadlock on a recursive event rwlock
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L0, when creating a list of events to wait on, in some cases was first grabbing a lock on a potentially completed event, and then tried to get a command list, which sometimes needs to cleanup all completed events. This caused a deadlock.
This patch moves getting a command list to before the event lock. But because the lock is required to decide whether this command list actually needed, we might be wasting time here.