Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec Constants] Improved handling of invalid spec. constants #1469

Merged
merged 1 commit into from
Oct 14, 2024

Commits on Oct 7, 2024

  1. [Spec Constants] Improved handling of invalid/unsupported spec. const…

    …ants
    
    Two main changes to how `Kernel/ProgramSetSpecializationConstants`
    are handled:
    * They may now output either `INVALID_VALUE` or the new
      `INVALID_SPEC_ID` when the provided list is invalid.
    * The OpenCL and level 0 adapters now respond to
      `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false`
      rather than erroring out. This fixes some tests that were
      incorrectly not being skipped.
    * `urKernelSetSpecializationConstants` now "implemented" (as a
      function that returns `UNSUPPORTED_FEATURE` for a number of
      adapters.
    RossBrunton committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f5979a6 View commit details
    Browse the repository at this point in the history