Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTS] Added test for sequencing events #1586

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

RossBrunton
Copy link
Contributor

@RossBrunton RossBrunton commented May 8, 2024

This tests that the urEnqueueEventsWaitWithBarrier function
functions as a barrier. That is, it blocks until all events prior
to it in the queue are completed. Since this test may fail
non-deterministically, it is ran a few times.

Note that current adapters seem to always execute events
sequentially, so this is a no-op.

@github-actions github-actions bot added the conformance Conformance test suite issues. label May 8, 2024
@RossBrunton RossBrunton force-pushed the ross/eventtest branch 2 times, most recently from b07f9b2 to 0692e2a Compare May 8, 2024 13:07
@RossBrunton RossBrunton marked this pull request as ready for review May 8, 2024 13:14
@RossBrunton RossBrunton requested a review from a team as a code owner May 8, 2024 13:14
@RossBrunton RossBrunton force-pushed the ross/eventtest branch 2 times, most recently from 099d64e to c89e77d Compare May 22, 2024 15:55
@RossBrunton RossBrunton force-pushed the ross/eventtest branch 2 times, most recently from 95b9792 to 3b5dece Compare August 13, 2024 15:54
@RossBrunton RossBrunton marked this pull request as draft August 23, 2024 15:20
@RossBrunton RossBrunton marked this pull request as ready for review October 10, 2024 11:45
@RossBrunton RossBrunton force-pushed the ross/eventtest branch 4 times, most recently from a9b47f9 to 48482a3 Compare October 10, 2024 15:53
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Oct 11, 2024
@RossBrunton RossBrunton force-pushed the ross/eventtest branch 6 times, most recently from a206fde to ecedb5e Compare October 14, 2024 11:10
@RossBrunton
Copy link
Contributor Author

@aarongreig You had a look at this way back in May, but it's been tweaked a bit since then. Mind giving it another look over just to ensure everything is still okay?

@aarongreig
Copy link
Contributor

still LGTM

@aarongreig
Copy link
Contributor

actually did you look into what's up with the level zero fail? in case it's something trivial

@pbalcer
Copy link
Contributor

pbalcer commented Oct 14, 2024

actually did you look into what's up with the level zero fail? in case it's something trivial

I was meaning to ask the same question. If barriers don't work in the L0 adapter, we need to fix that asap.

This tests that the `urEnqueueEventsWaitWithBarrier` function
functions as a barrier. That is, it blocks until all events prior
to it in the queue are completed. Since this test may fail
non-deterministically, it is ran a few times.

Note that current adapters seem to always execute events
sequentially, so this is a no-op.
@RossBrunton
Copy link
Contributor Author

Looks like it was complaining about the test not failing when the match file said it should. Probably due to an earlier version of the test being broken (I was breaking this rule #2195 ).

Hopefully this means that it's all actually passing on non-native-cpu targets.

@RossBrunton
Copy link
Contributor Author

Only adds conformance tests so should have no effect on intel/llvm. Merging without llvm change.

@RossBrunton RossBrunton merged commit 6f5c5ae into oneapi-src:main Oct 15, 2024
78 checks passed
@RossBrunton RossBrunton deleted the ross/eventtest branch November 6, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration/devliery conformance Conformance test suite issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants