-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CTS] Added test for sequencing events #1586
Conversation
b07f9b2
to
0692e2a
Compare
099d64e
to
c89e77d
Compare
95b9792
to
3b5dece
Compare
3b5dece
to
17d4598
Compare
17d4598
to
e230b3b
Compare
e230b3b
to
3dc7e64
Compare
a9b47f9
to
48482a3
Compare
a206fde
to
ecedb5e
Compare
@aarongreig You had a look at this way back in May, but it's been tweaked a bit since then. Mind giving it another look over just to ensure everything is still okay? |
still LGTM |
actually did you look into what's up with the level zero fail? in case it's something trivial |
I was meaning to ask the same question. If barriers don't work in the L0 adapter, we need to fix that asap. |
This tests that the `urEnqueueEventsWaitWithBarrier` function functions as a barrier. That is, it blocks until all events prior to it in the queue are completed. Since this test may fail non-deterministically, it is ran a few times. Note that current adapters seem to always execute events sequentially, so this is a no-op.
ecedb5e
to
759840e
Compare
Looks like it was complaining about the test not failing when the match file said it should. Probably due to an earlier version of the test being broken (I was breaking this rule #2195 ). Hopefully this means that it's all actually passing on non-native-cpu targets. |
Only adds conformance tests so should have no effect on intel/llvm. Merging without llvm change. |
This tests that the
urEnqueueEventsWaitWithBarrier
functionfunctions as a barrier. That is, it blocks until all events prior
to it in the queue are completed. Since this test may fail
non-deterministically, it is ran a few times.
Note that current adapters seem to always execute events
sequentially, so this is a no-op.