Use extension version of clGetKernelSubGroupInfo when necessary. #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LLVM PR: intel/llvm#15896 |
aarongreig
force-pushed
the
aaron/tryUseExtensionSubgroupInfo
branch
from
8d27b5c
to
bb58458
Compare
kbenzie
reviewed
Oct 31, 2024
source/adapters/opencl/kernel.cpp
Outdated
| cl_adapter::cast<cl_device_id>(hDevice), CL_DEVICE_PLATFORM, | ||
| sizeof(Platform), &Platform, nullptr)); | ||
| GetKernelSubGroupInfo = | ||
| reinterpret_cast<ApiFuncT>(clGetExtensionFunctionAddressForPlatform( |
There was a problem hiding this comment.
We should use the extension function pointer cache for this.
There was a problem hiding this comment.
Huh yeah forgot we had those, I cribbed from ProgramCreateWithIL when I wrote this since it's a similar cl version situation there, updated that as well
We do support at least one device (fpga emulator) that reports a cl version of < 2.1 and supports subgroups, in that scenario we need query out and use the KHR version of the entry point.
aarongreig
force-pushed
the
aaron/tryUseExtensionSubgroupInfo
branch
from
bb58458
to
d60c964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do support at least one device (fpga emulator) that reports a cl version of < 2.1 and supports subgroups, in that scenario we need query out and use the KHR version of the entry point.