[L0] Interrupt-based event implementation #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
winstonzhang-intel
force-pushed
the
interrupt-based
branch
2 times, most recently
from
7835bc8 to
28e7d38
Compare
EwanC
reviewed
Nov 22, 2024
pbalcer
approved these changes
Nov 27, 2024
nrspruit
reviewed
Dec 3, 2024
nrspruit
reviewed
Dec 3, 2024
winstonzhang-intel
force-pushed
the
interrupt-based
branch
from
f7fa435 to
1c3940b
Compare
To expose this functionality in UR, we want two ways of enabling low-power events: Queue-wide enabling so all events created on the queue are low-powered. As a property passed to urEnqueueEventsWaitWithBarrier making the resulting event a low-power event. This will require the existing interface to be extended with properties, potentially through a new experimental function. Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
interrupt-based
branch
2 times, most recently
from
379f325 to
fe798d6
Compare
…eueEventsWaitWithBarrierExt Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
interrupt-based
branch
from
93028f5 to
3a3bc06
Compare
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
nrspruit
approved these changes
Dec 3, 2024
Signed-off-by: Zhang, Winston <[email protected]>
nrspruit
approved these changes
Dec 3, 2024
nrspruit
reviewed
Dec 3, 2024
martygrant
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Dec 5, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 5, 2024
URT PR: oneapi-src/unified-runtime#2334 --------- Signed-off-by: Zhang, Winston <[email protected]> Co-authored-by: Martin Morrison-Grant <[email protected]>
al42and
reviewed
Dec 20, 2024
| eventSyncMode.syncModeFlags = | ||
| ZE_INTEL_EVENT_SYNC_MODE_EXP_FLAG_LOW_POWER_WAIT | | ||
| ZE_INTEL_EVENT_SYNC_MODE_EXP_FLAG_SIGNAL_INTERRUPT; | ||
| ZeEventPoolDesc.pNext = &eventSyncMode; |
There was a problem hiding this comment.
Hi! This stores a pointer to a temporary in ZeEventPoolDesc.pNext, and also potentially (with CounterBasedEventEnabled == true) overwrites the previously stored value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To expose this functionality in UR, we want two ways of enabling low-power events:
SYCL/LLVM: intel/llvm#16252