[DevASAN][CPU] bugfix for mmap return value check. #2402
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Dec 2, 2024
zhaomaosu
approved these changes
Dec 2, 2024
AllanZyne
reviewed
Dec 4, 2024
AllanZyne
approved these changes
Dec 4, 2024
|
Hi @aarongreig , could you help merge this fix? Thanks. |
Happy to merge right away as it's a trivial change but I'll need you to make the LLVM PR to update the tag. I would do it myself but you can't approve your own PR and there wont be another UR reviewer around to approve until late next week |
Thank you, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap()would returnMAP_FAILEDinstead of NULL in case of error, we need to do a translation here.Intel/llvm PR: intel/llvm#16466