Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bare issue numbers with URLs #2545

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/core/enqueue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,9 @@ desc: "Enqueue a command to fill an image object with specified color"
class: $xEnqueue
name: MemImageFill
ordinal: "0"
version: "9999.0" # see #50
# Will not be generated
# https://github.com/oneapi-src/unified-runtime/issues/50
version: "9999.0"
details:
- "Currently not implemented in Level Zero"
- "TODO: add a driver function in Level Zero?"
Expand Down Expand Up @@ -919,7 +921,9 @@ type: function
desc: "Enqueue a command to map a region of the image object into the host address space and return a pointer to the mapped region"
class: $xEnqueue
name: MemImageMap
version: "9999.0" # See #50
# Will not be generated
# https://github.com/oneapi-src/unified-runtime/issues/50
version: "9999.0"
ordinal: "0"
details:
- "Input parameter blockingMap indicates if the map is blocking or non-blocking."
Expand Down
8 changes: 6 additions & 2 deletions scripts/core/event.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,18 @@ etors:
desc: Event created by $xEnqueueMemImageWrite
- name: MEM_IMAGE_COPY
desc: Event created by $xEnqueueMemImageCopy
# Will not be generated
# https://github.com/oneapi-src/unified-runtime/issues/50
- name: MEM_IMAGE_FILL
desc: Event created by $xEnqueueMemImageFill
version: "9999.0" # See #50
version: "9999.0"
- name: MEM_BUFFER_MAP
desc: Event created by $xEnqueueMemBufferMap
# Will not be generated
# https://github.com/oneapi-src/unified-runtime/issues/50
- name: MEM_IMAGE_MAP
desc: Event created by $xEnqueueMemImageMap
version: "9999.0" # See #50
version: "9999.0"
- name: MEM_UNMAP
desc: Event created by $xEnqueueMemUnmap
- name: USM_FILL
Expand Down
3 changes: 2 additions & 1 deletion source/adapters/cuda/adapter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ class ur_legacy_sink : public logger::Sink {
};

// FIXME: Remove the default log level when querying logging info is supported
// through UR entry points. See #1330.
// through UR entry points.
// https://github.com/oneapi-src/unified-runtime/issues/1330
ur_adapter_handle_t_::ur_adapter_handle_t_()
: logger(logger::get_logger("cuda",
/*default_log_level*/ logger::Level::ERR)) {
Expand Down
3 changes: 2 additions & 1 deletion source/adapters/cuda/memory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@

/// Creates a UR Memory object using a CUDA memory allocation.
/// Can trigger a manual copy depending on the mode.
/// \TODO Implement USE_HOST_PTR using cuHostRegister - See #9789
/// \TODO Implement USE_HOST_PTR using cuHostRegister
/// https://github.com/intel/llvm/issues/9789
///
UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
ur_context_handle_t hContext, ur_mem_flags_t flags, size_t size,
Expand Down
3 changes: 2 additions & 1 deletion source/adapters/hip/adapter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class ur_legacy_sink : public logger::Sink {
};

// FIXME: Remove the default log level when querying logging info is supported
// through UR entry points. See #1330.
// through UR entry points.
// https://github.com/oneapi-src/unified-runtime/issues/1330
ur_adapter_handle_t_::ur_adapter_handle_t_()
: logger(
logger::get_logger("hip", /*default_log_level*/ logger::Level::ERR)) {
Expand Down
3 changes: 2 additions & 1 deletion source/adapters/hip/memory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemRelease(ur_mem_handle_t hMem) {

/// Creates a UR Memory object using a HIP memory allocation.
/// Can trigger a manual copy depending on the mode.
/// \TODO Implement USE_HOST_PTR using hipHostRegister - See #9789
/// \TODO Implement USE_HOST_PTR using hipHostRegister
/// https://github.com/intel/llvm/issues/9789
UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
ur_context_handle_t hContext, ur_mem_flags_t flags, size_t size,
const ur_buffer_properties_t *pProperties, ur_mem_handle_t *phBuffer) {
Expand Down
Loading