-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flags for live metrics and w3c tracing + URI filtering #6
base: master
Are you sure you want to change the base?
feat: add flags for live metrics and w3c tracing + URI filtering #6
Conversation
On second thought, it might be better to have a more conservative default for the |
I'd suggest to bump the major to v1 just to be 100% sure nothing breaks. We're testing the change internally in our fork and looks like the insights SDK is behaving slightly differently, we had to disable it during tests in a more specific way than what we used to be, but it might just be flaky tests on our side. Happy to provide more context/discuss if needed. |
@fmaule since you mentioned the different behaviour with the new SDK, would it be worth it if we split this PR into 2 different features: first the URI filter and then the new functionality offered by the new version? That would tackle one of your main concerns about the manifest metrics (and would also enable its usage in other services that don't require the new Azure features, like ours) and give you more time to investigate the differences. |
@neodmy that makes sense. I am sorry but given this took too long to get merged, I've added changes on our fork also to really disable azure-metrics when using it as a systemic component. That removes completely any issues during tests and also avoids unwanted network requests. Thanks, anyway |
New config flags (defaulted to false)
liveMetrics
(boolean): enable/disable the live metrics stream for insights: https://docs.microsoft.com/en-us/azure/azure-monitor/app/live-streamtraceW3C
(boolean): enable/disable correlation via W3C: https://docs.microsoft.com/en-us/azure/azure-monitor/app/correlationURI filtering via telemetry processor
ignoreURI
(default[]
]) is anstrings
array of URIs to be ignored: telemetry won't be sent for that specific request (eg. we're skipping logs for__/manifest
)