Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags for live metrics and w3c tracing + URI filtering #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fmaule
Copy link

@fmaule fmaule commented Feb 7, 2022

New config flags (defaulted to false)

URI filtering via telemetry processor

  • ignoreURI (default []]) is an strings array of URIs to be ignored: telemetry won't be sent for that specific request (eg. we're skipping logs for __/manifest)

@Betisman Betisman requested review from kevinccbsg and neodmy February 9, 2022 08:25
@fmaule
Copy link
Author

fmaule commented Feb 9, 2022

On second thought, it might be better to have a more conservative default for the ignoreURI to avoid breaking changes.
Let me know if I should also bump the version.

@kevinccbsg kevinccbsg removed their request for review February 14, 2022 12:12
@neodmy
Copy link

neodmy commented Feb 24, 2022

@Betisman @jgleal anyone with the right privileges you know of could merge and release the changes? Thanks

@fmaule
Copy link
Author

fmaule commented Feb 24, 2022

I'd suggest to bump the major to v1 just to be 100% sure nothing breaks.

We're testing the change internally in our fork and looks like the insights SDK is behaving slightly differently, we had to disable it during tests in a more specific way than what we used to be, but it might just be flaky tests on our side.

Happy to provide more context/discuss if needed.

@neodmy
Copy link

neodmy commented Feb 27, 2022

I'd suggest to bump the major to v1 just to be 100% sure nothing breaks.

We're testing the change internally in our fork and looks like the insights SDK is behaving slightly differently, we had to disable it during tests in a more specific way than what we used to be, but it might just be flaky tests on our side.

Happy to provide more context/discuss if needed.

@fmaule since you mentioned the different behaviour with the new SDK, would it be worth it if we split this PR into 2 different features: first the URI filter and then the new functionality offered by the new version? That would tackle one of your main concerns about the manifest metrics (and would also enable its usage in other services that don't require the new Azure features, like ours) and give you more time to investigate the differences.

@fmaule
Copy link
Author

fmaule commented Mar 2, 2022

@neodmy that makes sense.

I am sorry but given this took too long to get merged, I've added changes on our fork also to really disable azure-metrics when using it as a systemic component.

That removes completely any issues during tests and also avoids unwanted network requests.
I might raise a new PR here at a later stage, pulling from our fork. For now, we can probably just trash this PR, or you can use any part of it, if needed.

Thanks, anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants