Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: append paginator to body in data views #292

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: append paginator to body in data views #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3877f8f
fix: paginator appended to body
markuczy Jun 25, 2024
36f3ea2
fix: harness fix
markuczy Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/angular-accelerator/src/lib/components/data-list-grid/data-list-grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
currentPageReportTemplate="{{ (totalRecordsOnServer ? currentPageShowingWithTotalOnServerKey : currentPageShowingKey) | translate:params }}"
[rowsPerPageOptions]="[10, 25, 50, data?.length]"
id="dataListGrid_{{name}}"
paginatorDropdownAppendTo="body"
>
<ng-template let-item pTemplate="paginatordropdownitem">
{{ item.value === data?.length ? ("OCX_DATA_TABLE.ALL" | translate) : item.value }}
Expand Down
1 change: 1 addition & 0 deletions libs/angular-accelerator/src/lib/components/data-table/data-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
(selectionChange)="onSelectionChange($event)"
[selection]="(selectedRows$ | async) || []"
[scrollable]="true"
paginatorDropdownAppendTo="body"
>
<ng-template pTemplate="header">
<tr>
Expand Down
5 changes: 3 additions & 2 deletions libs/angular-testing/src/lib/harnesses/primeng/p-dropdown.harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ export class PDropdownHarness extends ContentContainerComponentHarness {

async getDropdownItems() {
await this.open()
const dropdownItems = this.locatorForAll(ListItemHarness)()
return await dropdownItems
const rootLocator = this.documentRootLocatorFactory()
const items = await rootLocator.harnessLoaderFor('.p-dropdown-items')
return await items.getAllHarnesses(ListItemHarness)
}

async getDropdownItem(itemText: string): Promise<ListItemHarness | null> {
Expand Down
Loading