[CAT-1728] Don't catch JSON decoding error on webhook event verification in Java #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvacca-onfido
force-pushed
the
improve-error-management-in-webhook-verifier
branch
from
7999ca7 to
3d452db
Compare
dvacca-onfido
changed the title
dvacca-onfido
changed the title
dvacca-onfido
force-pushed
the
improve-error-management-in-webhook-verifier
branch
from
89f70ea to
3d452db
Compare
RiccardoPetteruti-Onfido
approved these changes
Feb 18, 2025
sofia-gomes-onfido
approved these changes
Feb 18, 2025
dvacca-onfido
deleted the
improve-error-management-in-webhook-verifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to not catch
JsonParseExceptionand re-trow that as anOnfidoInvalidSignatureErrorwhen verifying webhooks events in onfido java.NB: this change need a major release.