Add github action to generate single API spec #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
3 times, most recently
from
3d14db7 to
8085b6c
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
7 times, most recently
from
f180d74 to
f1b998e
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
f1b998e to
0a25c96
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
9 times, most recently
from
94cfa62 to
32675d0
Compare
openapi.yaml
Outdated
| @@ -5,6 +5,7 @@ info: | |||
| version: 3.6.0 | |||
| contact: | |||
| name: Onfido | |||
| url: https://onfido.com | |||
| email: [email protected] | |||
There was a problem hiding this comment.
This should be support's email actually
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
32675d0 to
5c86ad1
Compare
| @@ -1,6 +1,6 @@ | |||
| # Onfido OpenAPI specification (beta) | |||
|
|
|||
| :warning: Our OpenAPI specification is currently in beta and we welcome any feedback. You can contact us via the issues tab or [email](mailto:openapi-feedback@onfido.com), but we don't yet officially support this specification. :warning: | |||
| :warning: Our OpenAPI specification is currently in beta and we welcome any feedback. You can contact us via the issues tab or [support portal](https://public.support.onfido.com), but we don't yet officially support this specification. :warning: | |||
There was a problem hiding this comment.
Should we consider that the spec is out of beta since we have all the reports ?
There was a problem hiding this comment.
I believe we should wait a little bit longer, to have at least one (generated) client library sufficiently tested to be definition maps quite well the actual API.
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
4a03471 to
70fdb3d
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
70fdb3d to
cab6e9c
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
cab6e9c to
e83b112
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
2 times, most recently
from
c14e8e3 to
7bc9de5
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
3 times, most recently
from
364654a to
aae5c88
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
aae5c88 to
ecbf6fd
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
3 times, most recently
from
9ded090 to
38ce035
Compare
RiccardoPetteruti-Onfido
approved these changes
Feb 27, 2024
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
38ce035 to
d6fd159
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
2 times, most recently
from
ee5a452 to
009c499
Compare
dvacca-onfido
force-pushed
the
generate-single-file-specs
branch
from
009c499 to
c63f0ae
Compare
DavidMealha-Onfido
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of Github Action workflow to build and push single-file OpenAPI specification.
Include validation of multi file specification and a few files which were forgotten in PR#42.