[Compiler+VM POC] Add compilation for inherited pre/post conditions #3729
+639
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
commented
Jan 16, 2025
Comment on lines
+419
to
+422
| // TODO: Merge this elaboration with the current elaboration (d.elaboration). | ||
| // Because the inherited functions need their corresponding elaboration | ||
| // for code generation. | ||
| elaboration, err := d.config.ElaborationResolver(interfaceType.Location) |
There was a problem hiding this comment.
Suffers from the same problem as default-functions. Need to figure out a way to universally solve this.
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3727 and #3728
Description
Similar to default functions (#3727), inherited function pre/post conditions are also copied over at AST level. Once they are copied over, they get compiled similar to normal inlined pre-post conditions (#3728)
masterbranchFiles changedin the Github PR explorer