Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Add tests for compiling casting expressions to casting instructions #3771

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 14, 2025

Depends on #3767
Work towards #3742

Description

Also add some test cases just for compiling the expressions to instructions.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 14, 2025 18:53
@turbolent turbolent self-assigned this Feb 14, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 14, 2025 18:53
Base automatically changed from supun/casting to feature/compiler February 14, 2025 19:18
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this 🙌

@turbolent turbolent enabled auto-merge February 14, 2025 19:21
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 63c1541
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit 74d6a39 into feature/compiler Feb 14, 2025
9 checks passed
@SupunS SupunS deleted the bastian/casting-tests branch February 14, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants