Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port internal fix #3778

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Port internal fix #3778

merged 3 commits into from
Feb 18, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 18, 2025

Description

Port https://github.com/onflow/cadence-internal/pull/313.

Also, adjust the comments and add some more tests.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

…urrent activation

pushing an additional activation would also have to get popped at the end
of the function call to ensure the activation stack stays balanced
@turbolent turbolent requested a review from jsproz February 18, 2025 22:39
@turbolent turbolent self-assigned this Feb 18, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 18, 2025 22:39
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f2feb7b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit ef26e0d into master Feb 18, 2025
12 checks passed
@turbolent turbolent deleted the bastian/v1.3-port-internal-fix-2 branch February 18, 2025 23:39
@turbolent turbolent changed the title [v1.3] Port internal fix Port internal fix Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants