Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add convenience method for getting prefixed address as string #554

Merged
merged 2 commits into from
Jan 9, 2024
Merged

add convenience method for getting prefixed address as string #554

merged 2 commits into from
Jan 9, 2024

Conversation

bthaile
Copy link
Contributor

@bthaile bthaile commented Jan 9, 2024

Closes: #553

Description

Add HexWithPrefix method so user's don't have to prepend "0x" to addresses and added unit tests.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bthaile bthaile mentioned this pull request Jan 9, 2024
Merged
6 tasks
@bthaile bthaile merged commit 1609bda into master Jan 9, 2024
1 check passed
@bthaile bthaile deleted the add-prefixed-hex-address branch January 9, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjartek bjartek bjartek approved these changes

@devbugging devbugging devbugging approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Address convenience method HexWithPrefix
3 participants
@bthaile @bjartek @devbugging