Merge pull request #6624 from AndriiDiachuk/time-to-seal-metrics-fix

Fixed issues where time-to-seal was NaN
onflow · Nov 8, 2024 · acbc34f · acbc34f
2 parents aaaf9be + 0ac69c1
commit acbc34f
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/module/metrics/transaction.go b/module/metrics/transaction.go
@@ -258,11 +258,6 @@ func (tc *TransactionCollector) TransactionFinalized(txID flow.Identifier, when
 
 	tc.trackTTF(t, tc.logTimeToFinalized)
 	tc.trackTTFE(t, tc.logTimeToFinalizedExecuted)
-
-	// remove transaction timing from mempool if finalized and executed
-	if !t.Finalized.IsZero() && !t.Executed.IsZero() {
-		tc.transactionTimings.Remove(txID)
-	}
 }
 
 func (tc *TransactionCollector) TransactionExecuted(txID flow.Identifier, when time.Time) {
@@ -280,11 +275,6 @@ func (tc *TransactionCollector) TransactionExecuted(txID flow.Identifier, when t
 
 	tc.trackTTE(t, tc.logTimeToExecuted)
 	tc.trackTTFE(t, tc.logTimeToFinalizedExecuted)
-
-	// remove transaction timing from mempool if finalized and executed
-	if !t.Finalized.IsZero() && !t.Executed.IsZero() {
-		tc.transactionTimings.Remove(txID)
-	}
 }
 
 func (tc *TransactionCollector) TransactionSealed(txID flow.Identifier, when time.Time) {
@@ -302,10 +292,8 @@ func (tc *TransactionCollector) TransactionSealed(txID flow.Identifier, when tim
 
 	tc.trackTTS(t, tc.logTimeToSealed)
 
-	// remove transaction timing from mempool if sealed
-	if !t.Sealed.IsZero() {
-		tc.transactionTimings.Remove(txID)
-	}
+	// remove transaction timing from mempool
+	tc.transactionTimings.Remove(txID)
 }
 
 func (tc *TransactionCollector) trackTTF(t *flow.TransactionTiming, log bool) {