-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement integration test for new websockets #6907
Open
UlyanaAndrukhiv
wants to merge
137
commits into
onflow:master
Choose a base branch
from
The-K-R-O-K:UlianaAndrukhiv/6641-websockets-integration-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Access] Implement integration test for new websockets #6907
UlyanaAndrukhiv
wants to merge
137
commits into
onflow:master
from
The-K-R-O-K:UlianaAndrukhiv/6641-websockets-integration-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Peter Argue <[email protected]>
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
…drukhiv/6641-websockets-integration-tests
…isarchuk/6573-pending-should-return-immediately
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
…' of github.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
We need to get this over with. The more time we don't review it, the more time we'll spend to recall what has been done in this PR. I have a capacity rn, so I'll review it on Monday if nothing special comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6641, #6876
Note: This PR related with #6737
Context
This pull request adds integration tests to verify the functionality of the new
WebSockets
implementation and incorporates the following updates:Fixes from integration test results.
Errors identified during integration testing have been resolved, ensuring stable and expected behavior for all supported scenarios.
Max subscriptions per connection functionality.
The functionality has been implemented, enforcing a limit on the number of active subscriptions allowed per
Websocket
connection.Integration test scenarios:
Happy paths:
Error cases:
subscribe
with invalid data.unsubscribe
with invalid data.Additional behaviors:
Websockets
MaxSubscriptionsPerConnection limits functionality