Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implement integration test for new websockets #6907

Open
wants to merge 137 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 16, 2025

Closes: #6641, #6876

Note: This PR related with #6737

Context

This pull request adds integration tests to verify the functionality of the new WebSockets implementation and incorporates the following updates:

  1. Fixes from integration test results.
    Errors identified during integration testing have been resolved, ensuring stable and expected behavior for all supported scenarios.

  2. Max subscriptions per connection functionality.
    The functionality has been implemented, enforcing a limit on the number of active subscriptions allowed per Websocket connection.

  3. Integration test scenarios:

  • Happy paths:

    • Subscribing to any topic, ensuring a successful subscription response and expected results.
    • Unsubscribing from a topic successfully.
  • Error cases:

    • Attempting to subscribe with invalid data.
    • Attempting to unsubscribe with invalid data.
  • Additional behaviors:

    • Retrieving a list of all active subscriptions.
    • Verifying client inactivity tracking and connection loss handling.
    • Verifying the Websockets MaxSubscriptionsPerConnection limits functionality

Guitarheroua and others added 30 commits November 15, 2024 15:18
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
@Guitarheroua Guitarheroua changed the title [Access] Implement integration test for new websockets [WIP] [Access] Implement integration test for new websockets Jan 28, 2025
@Guitarheroua Guitarheroua marked this pull request as ready for review January 31, 2025 13:49
@Guitarheroua Guitarheroua requested a review from a team as a code owner January 31, 2025 13:49
@illia-malachyn
Copy link
Contributor

We need to get this over with. The more time we don't review it, the more time we'll spend to recall what has been done in this PR. I have a capacity rn, so I'll review it on Monday if nothing special comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Implement integration test for new websockets
5 participants